feat(dh): apollo data source #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 82b4764. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
ManBearTM
had a problem deploying
to
AzureAuth
GitHub Actions
Failure
Test results for \apps\dh\api-dh\source\DataHub.WebApi.Tests\bin\Release\net8.0\Energinet.DataHub.WebApi.Tests.dll1 tests 1 ✅ 2m 42s ⏱️ Results for commit edaa4e6. ♻️ This comment has been updated with latest results. |
ManBearTM
had a problem deploying
to
AzureAuth
GitHub Actions
Failure
ManBearTM
had a problem deploying
to
AzureAuth
GitHub Actions
Failure
ManBearTM
had a problem deploying
to
AzureAuth
GitHub Actions
Failure
mimse
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the new ApolloDataSource, which is a Material DataSource implementation that is meant to be used with the new auto-generated DataSource classes. When you add
UsePagingandUseSortingto a list query in the BFF (and update the related.graphqloperation file), a corresponding DataSource class will be generated in thegraphql.tsfile. For example, if you were to add paging and sorting to thegridAreasquery, a new class namedGetGridAreasDataSourcewill be available ingraphql.ts. This can be used directly withwatt-tableto get a fully server-side paginated and sort enabled table. The DataSource also enables thefilterfunction (search field in the table). Just add a string parameter namedfilterto the paginated query in the BFF.The PR also implements this new functionality for the calculations table. Since that table is now fully server-side paginated, I had to make some changes to the subscription part. It ended up simplifying the logic quite a bit, with the only caveat that calculations that others create are not automatically added to the list (this might not even be a bad thing). Instead we use
refetchQueriesnow when you create a new calculation.References